refactor(opam): share modern build command generation - #15550
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
Parameterize the Dune 3 build command template by its runtest alias instead of maintaining separate templates for package-local runtest aliases. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors opam build: command generation for Dune 3.x by parameterizing the modern build-command template with a configurable runtest alias (to avoid maintaining separate templates for package-local runtest aliases).
Changes:
- Consolidate the Dune ≥ 3.0 build-command generator to accept a
~runtestargument. - Update version/
exclusive_dirbranching to pass either@runtestor@runtest/<dir>into the shared generator. - Remove the need for a separate Dune 3.23+ template by reusing the parameterized one.
Comment on lines
+65
to
68
| and from_3_0 ~with_subst ~with_sites ~runtest = | ||
| let subst = if with_subst then {| [ "dune" "subst" ] {dev} |} else "" in | ||
| let promote_install_files = | ||
| if with_sites then {| "--promote-install-files=false" |} else "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterize the Dune 3 build command template by its runtest alias instead of maintaining separate templates for package-local runtest aliases.